[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 16/29] libs,tools/include: Clean "clean" targets


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Thu, 3 Mar 2022 16:00:05 +0000
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 03 Mar 2022 16:00:29 +0000
  • Ironport-data: A9a23:yCc+kaLvrPjYtzSeFE+R0JUlxSXFcZb7ZxGr2PjKsXjdYENShDYOz 2NLWjvQaf7fajH0eo0iaYSxoxgOv5WBmIRhQANlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh2dYz2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 PNLn4SRTxkFB/Tzvb4wXDtfNR9HbLITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ6uFP ZVFN2IHgBLoXSJfFUUvJaAHgNyLoUvZSy9UsAiRuv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4cEhoNTnOgvOK0zEW5Xrpix 1c8o3R06/JorQryE4e7D0bQTGO4UgA0fdx6C8w89i20k5XxuSuWJG8icAcQd4lz3CMpfgAC2 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb5 hDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0gfhs3bpdfJmKwC KM2he+3zMUJVJdNRfUqC79d9uxwlfSwfTgbfqq8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy r/AGftA+U0yUPw9pBLvHr91+eZymkgWnDqDLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq I0BXyZLoj0CONDDjt7/qtZCfQhXdiFgXfgbaaV/L4a+H+avI0l5Y9e5/F/rU9ANc3h9/gsQw kyAZw==
  • Ironport-hdrordr: A9a23:Yeh4t6wP3sdKfCEc7DBkKrPxmuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBZpTnyAtj6fZq8z+8/3WB1B9uftWbdyQ+Vxe1ZjLcKhgeQYhEWldQtn5 uIEZIOb+EYZGIS5amV3OD7KadH/DDtytHKuQ6q9QYJcegcUdAD0+4WMGamO3wzYDMDKYsyFZ Ka6MYCjSGnY24rYsOyAWRAd/TfpvXQ/aiWLSIuNloC0k2jnDmo4Ln1H1yzxREFSQ5Cxr8k7C zsjxH53KO+qPu2oyWsmFM7rq4m1ucJ+OEzRPBkufJlaQkETTzYJriJbofy/QzdZtvfrWrC3u O85yvIdP4DkU85NlvF3CcFnTOQnQrGokWStWOwkD/tp9f0Syk9DNcEjYVFcgHB405lp91k1r lXtljpwaZ/HFfOhyL4o9fBUBZrmk69rT4+nekaiGE3a/psVFZ9l/1qwKpuKuZ2IMs60vFWLM B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpR+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOFl7fnpLEuoO26cp0By5U/3J zHTVNDrGY3P1njDMWftac7hywlgF/NLwgF5vsumaSR4IeMO4YDGRfzOWwTrw==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Mar 03, 2022 at 09:21:48AM +0100, Juergen Gross wrote:
> On 25.02.22 16:13, Anthony PERARD wrote:
> > diff --git a/tools/include/Makefile b/tools/include/Makefile
> > index d965987f55..3a03a0b0fa 100644
> > --- a/tools/include/Makefile
> > +++ b/tools/include/Makefile
> > @@ -82,6 +82,7 @@ uninstall:
> >   clean:
> >     rm -rf xen xen-xsm acpi
> >     $(MAKE) -C xen-foreign clean
> > +   rm -f _*.h
> 
> Use $(RM) instead? OTOH this could be done in a patch of its own
> switching all rm -f instances to $(RM).

This isn't really something that I think matter. Per GNU make's manual,
"rm" need to exist. Without it part of the build system could be broken.
Also setting $(RM) to something other than "rm -f" isn't going to work
well either. So whether we use $(RM) or `rm -f` shouldn't matter.

All of that to say that I'm not necessarily change one for the other. It
mostly depends on context.

Also, I might change those "clean:" rules later to collect files to
clean in a variable $(&CLEAN_FILES), when that will be possible.

> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.