Re: [XEN PATCH v2 16/29] libs,tools/include: Clean "clean" targets

[Juergen Gross <jgross@xxxxxxxx>]

On 25.02.22 16:13, Anthony PERARD wrote:
> There is no need for an extra "cleanlocal" target, we can use
> double-colon rules instead.
>
> Generated headers are now in tools/include/, so remove those file
> there.
>
> Remove -f flag as it's already in $(RM).
>
> libs.mk:
>    - don't try to remove "*.rpm" anymore.
>
> libs/light:
>    - "_paths.*.tmp" isn't created anymore.
>    - clean "libxenlight_test.so" and "libxl_test_*.opic".
>
> libs/stat:
>    - don't remove $(DEPS_RM) from here as it is already done in
>      "libs.mk".
>
> libs/util:
>    - fix clean of version-script file.
>
> include/xen-foreign:
>    - remove __pycache__
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Notes:
>      v2:
>      - stop removing $(DEPS_RM) from libs/stat/Makefile.
>
>   tools/include/Makefile             |  1 +
>   tools/include/xen-foreign/Makefile |  1 +
>   tools/libs/ctrl/Makefile           |  5 +----
>   tools/libs/guest/Makefile          |  3 +--
>   tools/libs/light/Makefile          | 19 ++++++++-----------
>   tools/libs/stat/Makefile           |  8 ++------
>   tools/libs/util/Makefile           |  7 ++-----
>   tools/libs/vchan/Makefile          |  5 +----
>   tools/libs/libs.mk                 |  4 ++--
>   9 files changed, 19 insertions(+), 34 deletions(-)
>
> diff --git a/tools/include/Makefile b/tools/include/Makefile
> index d965987f55..3a03a0b0fa 100644
> --- a/tools/include/Makefile
> +++ b/tools/include/Makefile
> @@ -82,6 +82,7 @@ uninstall:
>   clean:
>         rm -rf xen xen-xsm acpi
>         $(MAKE) -C xen-foreign clean
> +       rm -f _*.h
Use $(RM) instead? OTOH this could be done in a patch of its own
switching all rm -f instances to $(RM). Either way is fine with me, so:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature