[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 24/30] build: grab common EFI source files in arch specific dir
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 3 Mar 2022 15:41:25 +0000
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 03 Mar 2022 15:41:36 +0000
- Ironport-data: A9a23:czCoa6jfUEqlTUeiEKHpHbd2X161gRAKZh0ujC45NGQN5FlHY01je htvUTyCa66CNmH3c4hzbYng80gCuZfXztFrTQBqriwyF3kb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWFvW4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YR8GE6vvlsteagFFCid9fp9+wq35LVHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i 88xN2czNEqfPkAn1lE/KY4ht+6Qt3LDazhJrEvKmukR4mrJ9VkkuFTqGIWMIYHbLSlPpW6mo WbB83X8EwstHtWVwjqY8VqhnubK2yj8Xeo6HrCi6uRjhlHVw2UJEQAXTnOyu/z/gUm7M/pPJ kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwB6J4rrZ5UCeHGdsZjxLZcEitcQ2bSc3z VLPlNTsbRRtrbmURHS15rqS6zSoNkA9NnQebCUJSQ8E5djLo4wpiB/LCNF5H8aIYsbdQG+qh WrQ9W5n2utV3ZVjO7iHEU7vmx2BoLvHYU0M/hjOWGHm3DtDdrCpTtn9gbTE1spoIIGcR1iHm XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2Vd0IuFlDyFFV3tHokNMDS Gvaoktv6ZBaJxNGhocnMtvqW6zGIUUNfOkJt8w4jPITOvCdlyfdpUmCgHJ8OUi3yiDAdollZ P+mnT6EVypyNEie5GPeqx0h+bEq3Dsi4mjYWIr2yR+quZLHOiLLE+tbbArVMb1ghE9hnOkz2 4wFXydt408CONASnwGNqdJDRbz0BSJT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwO/tokC kqVAxcCoHKm3CWvAVzTNhhLMeq/Nb4i/SNTFXF9Zj6Ahil8CbtDGY9CLvPbi5F8r7c9pRO1J tFYE/i97gNnEWyWq2xANsCm9OSPtn2D3GqzAsZsWxBnF7YIeuAD0oaMktfHnMXWMheKiA==
- Ironport-hdrordr: A9a23:IMJNXq3fluYrFFRgFvQECAqjBLAkLtp133Aq2lEZdPRUGvb4qy mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOceEYZmIbsS+V2meFL+o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 03, 2022 at 11:37:08AM +0100, Jan Beulich wrote:
> On 25.01.2022 12:00, Anthony PERARD wrote:
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -77,8 +77,9 @@ obj-$(CONFIG_COMPAT) += x86_64/platform_hypercall.o
> > obj-y += sysctl.o
> > endif
> >
> > -# Allows "clean" to descend into boot/
> > +# Allows "clean" to descend
> > subdir- += boot
> > +subdir- += efi
>
> No similar addition is needed for Arm?
No, because Arm already have "obj-$(CONFIG_ARM_64) += efi/", which has
the same effect on clean.
Make clean doesn't use ${ALL_OBJS} to find out which directory to clean, so
adding "subdir-" is needed at the moment.
> > --- /dev/null
> > +++ b/xen/common/efi/efi-common.mk
> > @@ -0,0 +1,15 @@
> > +EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o
> > +EFIOBJ-$(CONFIG_COMPAT) += compat.o
> > +
> > +CFLAGS-y += -fshort-wchar
> > +CFLAGS-y += -iquote $(srctree)/common/efi
> > +
> > +# Part of the command line transforms $(obj) in to a relative reverted
> > path.
> > +# e.g.: It transforms "dir/foo/bar" into successively
> > +# "dir foo bar", ".. .. ..", "../../.."
> > +$(obj)/%.c: $(srctree)/common/efi/%.c FORCE
> > + $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /,
> > ,$(obj))))/common/efi/$(<F) $@
>
> What is the "reverted" about in the comment? Also (nit) I think you want
> s/in to/into/.
I've tried to described in the single word that the result is a relative
path that goes in the opposite direction to the original relative path.
Instead of going down, it goes up the hierarchy of directories.
Maybe "reversed" would be better? Do you have other suggestion?
Thanks,
--
Anthony PERARD
|
