Re: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 5 Nov 2021, Bertrand Marquis wrote:
> Hi Stefano,
> 
> > On 4 Nov 2021, at 22:48, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> > 
> > On Wed, 3 Nov 2021, Vikram Garhwal wrote:
> >> Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
> >> This update is done to support device tree overlays.
> >> 
> >> A few minor changes are done to make it compatible with Xen:
> >> fdt_overlay.c: overlay_fixup_phandle()
> >>    Replace  strtoul() simple_strtoul() as strtoul() is not available in 
> >> Xen lib
> >>    and included lib.h.
> >>    Change char *endptr to const char *endptr.
> >> 
> >> libfdt_env.h:
> >>    Changed path for config.h and stdbool.h. Remaining Xen changes to
> >>    libfdt_env.h carried over from existing libfdt (v1.4.0)
> > 
> > Hi Vikram, thanks for the patch!
> > 
> > Would you be able to split this patch into two patches:
> > 
> > - the first patch pulls in the new libfdt
> > - the second patch makes the necessary changes to make it compatible
> >  with Xen
> > 
> > I understand that the first patch alone would break the build, but they
> > can be easily squashed together on commit. And reading the two patches
> > separately it would make them a lot easier to review.
> 
> Actually the diff will be quite small and limited to what was said by Vikram
> here but will break the build.
> 
> I manually checked by comparing libfdt directory in xen with the one in dtc
> and could not find other differences than the one mentioned by Vikram or
> stuff done before in Xen in the env header which was carried over.
> 
> So I would not say splitting is needed here.

OK, thank you so much for looking into it!