Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 5 Nov 2021, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on 
> arm64"):
> > I had a question for Jan, but in reply to the previous version of the
> > patch so you might have missed it:
> > 
> > https://lore.kernel.org/all/alpine.DEB.2.22.394.2111050825240.284830@ubuntu-linux-20-04-desktop/
> 
> Ah.  Yes.  I saw that but hadn't realised it might be a blocker.
> 
> > However, the concern is about resource utilization and slowness, rather
> > than correctness, so I think the version of the patch you committed
> > should work OK (unless it turns out that with broken EFI firmware
> > opening HandleProtocol/OpenVolume and closing it many times causes
> > some sort of error.) So maybe for 4.16 we are OK as is and we can make
> > any changes (if necessary) for 4.17.
> 
> I hope you are OK with this being in-tree now.  If not please let me
> know ASAP and I could revert it.  I'd be happy to consider a followup
> patch on its merits, of course.

As mentioned on IRC, I would keep it. I think it should be OK, the only
potential issues are:
- slowness (not a blocker)
- broken firmware (this is me being a bit paranoid, with firmware one
  never knows)

We can address both later separately if we need to.