[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 5 Nov 2021 14:48:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yb9cHsz5nA2sjAqdyO5YpbFgoJdxUPeYCL/2YE2yDBA=; b=mWxggqXTQO7oXV0CtI0OBKVOzeMc+voIFCDRrzb8MI1mEqtGV/+XPUt677Lg0KVI4Atpxf3FKvXHH/Eno1Q7nb0Q3xTsWAawOzXQsVowdSs5qXotTkNTOOMj0ALh/0SEZFKT9uGNgz0xgZMkDFhhVlXXhnPyWp3HdpDmHQMxT9kBId+ZdGfRpYoaPmm68FzZePYtz692GLsbMXWeKX2gttoNx7XoFDTAyc3qFdFYJCPXCYapgdIegqM2FSyIOTkEMN11AUrGUZtn93TFhn6uKVWQjhDUFTBTOlPPbQOZkpR0ep8w6ciIuy9tugWtcfMAbWchAAvU7zldG/fmzxRVYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HgbCG7RU/emrwCRVBuf5aZcxc2T1JfWrbL00UvIBGxEKoOld944ie9URVPTt6aG/xq8EEq2weEuzubtfKBKLO9SvxNupCddx43U8R+VmDUUV944JIykz90bnVL09kyEvr4Hg+0Wl3LhSbg4EQ8+lWfsgmV4PjDerwiQuE9WE2ALlwSgL4FrZ520a7hIFLqa1Y3CcPHFvjeoK3Ly8JszFOH7Jp05HnUhEBbB3aYm7MZ/s7Q+5wp8XXOu0a/961sPZrf+CmjdZDrHKA4UZNX3Pr2lSJ8Q1rPClZyEDOrV8EhrN6+sWSTySru5lg3WRT+mhexkLNrAZDZAWsMoJJW97hA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Fri, 05 Nov 2021 14:49:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHX0UQblDQwk25oXUS4+EmFAqHUdKvz+asAgAEMUwA=
- Thread-topic: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1
Hi Stefano,
> On 4 Nov 2021, at 22:48, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> On Wed, 3 Nov 2021, Vikram Garhwal wrote:
>> Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
>> This update is done to support device tree overlays.
>>
>> A few minor changes are done to make it compatible with Xen:
>> fdt_overlay.c: overlay_fixup_phandle()
>> Replace strtoul() simple_strtoul() as strtoul() is not available in Xen
>> lib
>> and included lib.h.
>> Change char *endptr to const char *endptr.
>>
>> libfdt_env.h:
>> Changed path for config.h and stdbool.h. Remaining Xen changes to
>> libfdt_env.h carried over from existing libfdt (v1.4.0)
>
> Hi Vikram, thanks for the patch!
>
> Would you be able to split this patch into two patches:
>
> - the first patch pulls in the new libfdt
> - the second patch makes the necessary changes to make it compatible
> with Xen
>
> I understand that the first patch alone would break the build, but they
> can be easily squashed together on commit. And reading the two patches
> separately it would make them a lot easier to review.
Actually the diff will be quite small and limited to what was said by Vikram
here but will break the build.
I manually checked by comparing libfdt directory in xen with the one in dtc
and could not find other differences than the one mentioned by Vikram or
stuff done before in Xen in the env header which was carried over.
So I would not say splitting is needed here.
Cheers
Bertrand
>
|
