[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

On 02.06.21 12:43, Olaf Hering wrote:
Am Wed, 2 Jun 2021 08:09:00 +0200
schrieb Juergen Gross <jgross@xxxxxxxx>:

-    if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN )
+    if ( ctx->save.debug )
This is no documentation change IMO. You should either mention this
modification in the commit message, or put it into a separate patch.

I think the conclusion was that this branch is dead code because
only the stream_type==XC_STREAM_PLAIN code branch sets debug.

So far there is a decision to be made about this code branch:
- document it
- remove it
- fix it

I don't mind either way. I just pointed out an inconsistency between
patch title and content. When searching for a patch causing a regression
I usually skip documentation patches.


Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.