[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v20210601 02/38] xl: fix description of migrate --debug

  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Wed, 2 Jun 2021 12:43:24 +0200
  • Arc-authentication-results: i=1; strato.com; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1622630612; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cp5ejae4nR+8FjxdlK6xVBZLvaHpWZO8UIYNCx9OGdk=; b=aPRsWfQL2FBKbwokeAVgJk+aOx8VIAZ117/gI/n/qz0YG4AMdpFGQKim6zMij5U9NX XBIXdtfhWwJJ6bA35utpBgCDyG84JzN3AQ1riZHaJgTKBl3gjR84nl5pSHpLNEfmZ4d0 YPQkoJADzVetkPzKJgs+3LOPcGnEbEeaWNGN+N395JfIuGR3DD5ktTyxlcwriyQOO6WL re2yzJ/JmX44c0fsW312pja1Q0r9R7XCf1thI91xHIc+vaA/AFL6qqvt2myv98C2RPiR IsI/FfkwyY1ia7IPOL4MS5pb0bES0Q3Wqg6Idrwm9TBIj4ZsPGI9trb4dw4Lnh6sK02d st+w==
  • Arc-seal: i=1; a=rsa-sha256; t=1622630612; cv=none; d=strato.com; s=strato-dkim-0002; b=Hn+VMaCzwXi+Dbsyabk6p4NRP1srElc30vcisnlESTcDuEE6Fj3oEIthlR9UjaApnD 1NYvcUJzZktdt20hlBMsOFsu8sUdy5FKYSkvkz0inyLEW9nBdQIibvEf5bFurW+SI5tU XNf76Gl0bVSu7KsQf9Z+aMqZvL9hvI9jz+hnd9X+GryZHYXRnrqPfU0KMf46MRxCVOKr 08XsUIcPLhnUQId9qWtTB0erY7+c6gl2XDdyZjavcH3HbEJ6ZjZvDBZM8dr1xw2TZf49 bADcHTkV+MsjuMye0NsIbZxQlPC/MxHEcAb/7sHwITNf1go0KE+NGCnvbp+eitCgOyTQ 0lDQ==
  • Authentication-results: strato.com; dkim=none
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 02 Jun 2021 10:43:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Am Wed, 2 Jun 2021 08:09:00 +0200
schrieb Juergen Gross <jgross@xxxxxxxx>:

> > -    if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN )
> > +    if ( ctx->save.debug )  
> This is no documentation change IMO. You should either mention this
> modification in the commit message, or put it into a separate patch.

I think the conclusion was that this branch is dead code because
only the stream_type==XC_STREAM_PLAIN code branch sets debug.

So far there is a decision to be made about this code branch:
- document it
- remove it
- fix it

The latter might be impossible due to lack of APIs to query the usage of a 
given page.

But, perhaps remus and/or colo does not suffer from apparent corruption.
One day I should create a remus and a colo setup to exercise these code paths. 


Attachment: pgpCzqSGjr6PW.pgp
Description: Digitale Signatur von OpenPGP



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.