[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v20210602 02/38] xl: fix description of migrate --debug


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Wed, 2 Jun 2021 14:32:36 +0200
  • Arc-authentication-results: i=1; strato.com; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1622637157; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=JWdlTkXOkgDN7Clt1j9YLt2cHeC41eQucSJbB7W4054=; b=licgU8qa2ZoQswWGYaLxd7Y7KK25vSBFTcAt/L+IzClHxFbTHUNceyBPLiesKlwm15 PF8ZIQax02sPq8HHMxMGRyOt3xmVwBeepL6TNl2QnRwcEqrfSIASDHkI3kNo5ryWd4Qp CRoodtCAOVtR+wQpZZyfnh3al1r60tIFpI2xgrA9Vl7E9hramkEjbdor95zGz8zJ0otb yRWq0/JzdygFsZijffbh60OvbCQIJBx5vgVHtFFHxkfzIjC9GuiBYqibWYrNhE9Y5jWk Hou4l5wmBecSiQKbQ2yzieqxmpx8Iunl1QDIDwTwWFbOiJp4Y6U1JWWkWjA9DhRaeRLv 6pKA==
  • Arc-seal: i=1; a=rsa-sha256; t=1622637157; cv=none; d=strato.com; s=strato-dkim-0002; b=ISWKGepvFv99Q9VNMOvqDUhkJliYEJDAJyAdjWpfxRi1ao6v27utIfPEpQyaMJzg5S k3IzuZrxTKBoLZMHkTcnCGrM0VlVu943Rtv4MpU5RrSMercfrY085NnGWhftcQ911AIm VeIr0vFSDKgmiTS9yeFa89do9TkfFSgL5SfrIeKwSvK0BqkPt6Udj+ku9xCVsZVcH4W/ itaAjgcDSZL3es7yJsnMRSKDPLhDarh4w9V37SEDP0NMf6aaM+UbLDkzACbGi/v5hpuC aUA52mbIyWXLsSA+FjR20CcDRcPC0JXG5urd2PZs/P783mhBH6Jw+zon6kApY6n1/qfz hxMw==
  • Authentication-results: strato.com; dkim=none
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 02 Jun 2021 12:32:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

xl migrate --debug used to track every pfn in every batch of pages.
But these times are gone. The code in xc_domain_save is the consumer
of this knob, but it considers it only for the remus and colo case.

Adjust the help text to tell what --debug does today: Nothing.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

v02:
- the option has no effect anymore
---
 docs/man/xl.1.pod.in   | 2 +-
 tools/xl/xl_cmdtable.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
index e2176bd696..70a6ebf438 100644
--- a/docs/man/xl.1.pod.in
+++ b/docs/man/xl.1.pod.in
@@ -481,7 +481,7 @@ domain.
 
 =item B<--debug>
 
-Display huge (!) amount of debug information during the migration process.
+This option has no effect. It is preserved for compatibility reasons.
 
 =item B<-p>
 
diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
index 661323d488..ca1dfa3525 100644
--- a/tools/xl/xl_cmdtable.c
+++ b/tools/xl/xl_cmdtable.c
@@ -172,7 +172,7 @@ const struct cmd_spec cmd_table[] = {
       "                migrate-receive [-d -e]\n"
       "-e              Do not wait in the background (on <host>) for the 
death\n"
       "                of the domain.\n"
-      "--debug         Print huge (!) amount of debug during the migration 
process.\n"
+      "--debug         Ignored.\n"
       "-p              Do not unpause domain after migrating it.\n"
       "-D              Preserve the domain id"
     },



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.