[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15] tools/configure: add bison as mandatory

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 5 Feb 2021 15:04:20 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=brzd3fHckUGI+bOjKdCAJYyz8fn7/y7WDdrmge4fyEU=; b=KsMLW9mLuMseB/qfEupTykPGaqHS3Hd3FI69Uk7C3ICJgc/BixARkYsDi5q5FaeLtcMX2Uw5dSIdnAQx1ZGcZGgcpvSD+HAWOgTuByB50gfXTL6PsSN1gOQy/PQXzdyUdEl52RCgO1YYx1iGbX9IGJJTK4kEnpauB1n0w3bc3DRZzFuEzsfAjvtV4cqEiVGis8uVftsrWR4kSUDp04lAD1Jl4IotyD0+aZoq+ZmBrBNjZ4XYVsLOiDQQTYyWQVpJT0NaDzLCQsk0dqY5HrEJXpuAzeip0RqNCJuTjRgr5R8C4eqwK0plHFFJYkwk1a67P1YnjPbu52wDRKY0xi3FZQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBWUDjG2WdUDJPea045EtRZBUniMdJwbc7s9aJyzY+dvhJgVUe6Ivm8PYlCEYAfGOamAigh0JJuVFb4zRn9yC2SbxOQOMgZ3y0jMx+fAg5ISv+fv1N54Z8TgVV9dbxM6dKjPu3h7T95PcnCvQ0OiHzb0UD+wenO/IJPeZnoUY7g/pTO7NiaM0Mo+fWDjyXmfn3VcuxqP+1dTchahjNGb6Vf17F3C7k2mzPJ40tNREhyL2Zdlbm6RFsO4RL0EjsKPuRK942gTsmyOmcfIiaHx3gk5Bb2QaWREZkhEjRwW/i+qEx5qQuZDuDl0xWhZ8kP7Q+PnkZ0XCABFZkNpJzuOKg==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 05 Feb 2021 14:04:35 +0000
  • Ironport-sdr: KiT6cgX95AHYOCPGXK5UboeOPbRusiVRzkOh05PzGOkHr+L/EBlprXuOtYUXuAuMKkhJ2Ica+j dJX41CtdSLY8QxZMCzDApN+uYeLPmnxKRotAPCvGP7SxgLs6brRIOYIw21qBJAkKuFSNLj6Ar0 XLm+QNmlHPBdEFmXRzpNBi9R2T6Mi6lUVJk61twOfr7TYb6fLLm8Xty/d1gE5gOsSFt0VRj023 wWfCHIcHgnTj/hym2Kqz7QjCVv+DWCRLew+jjg239fFGdLoE6BudAMPIVu19mby0toBX2mAzgn UXY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Feb 05, 2021 at 01:50:27PM +0000, Andrew Cooper wrote:
> On 05/02/2021 13:39, Roger Pau Monné wrote:
> > On Fri, Feb 05, 2021 at 01:34:20PM +0000, Andrew Cooper wrote:
> >> On 05/02/2021 11:53, Roger Pau Monne wrote:
> >>> Bison is now mandatory when the pvshim build is enabled in order to
> >>> generate the Kconfig.
> >>>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >>> ---
> >>> Please re-run autogen.sh after applying.
> >>>
> >>> Fallout from this patch can lead to broken configure script being
> >>> generated or bison not detected correctly, but those will be cached
> >>> quite quickly by the automated testing.
> >> I think this can be simpler.  Both flex and bison are mandatory libxlutil.
> > No, we ship the output .c and .h files so that the user only needs to
> > have bison/flex if it wants to modify the .l or .y files AFAICT?
> I know that theory, but it is broken in practice because of `git
> checkout` timestamps.
> Also, the Makefile explicitly enforces the checks, so they are mandatory
> in despite an attempt to ship the preprocessed form.

I seem to be able to `make -C tools/libs/util/` just fine without
having bison installed. If we do require bison/flex then we certainly
need to remove the output *.c/*.h files from tools/libs/util/.

I'm not specially thrilled either way, but I think the proposed patch
is safer given the point of the release we are at.

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.