[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15] tools/configure: add bison as mandatory
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Feb 2021 13:50:27 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z2UDGZRnpcoDmRxQ7SFncx43i0q3V6ykywWkgxPmIMc=; b=oZdLp+wbAbBKLbvPhf2LKavh1juv507DZa+cek0I93vn29ZJb8UoqN0MLbrRXVdAjMgekA2e6eJP7XIc5Sznd/UvcWmXOE2ZujqKi2RCHZZAXS7SIU/U9zGEWyYoiKU/wIWFrLrh7HUP/cD/zVQoqvUvKfUJ3MFbFyW9f4au0/dL2gm2DvBmQs7KA/xNDh4scDKSIRv9mb3hw/X99sKjsc+jVnlpf2U4AQo8BupxO59DOv/r5+q96kkAyr/uA4BCMvLPubKrENDKHTytjEIlIzCL72LIJQNfHu3vsg0ioeb0MN/An6GRiHH7s+AX3ArYKMU+CUuC8Vcr7raQT7J6UQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tbwd4ruA+nnitmJZrVlI3kvVtGenGNxwmtCN/GsJOb4ZiT1FF/Ak2L3MQCpeF13uLHwOXohgJAZzmQSe5hDzGxzecnxaCYqZeqxTZPXl2G/tvmR9XmcBEQVqtMo/AMQES6/oDO4XXvjMHxwwQ3Jt70C1naGae4Vg40OzR1pra+fw8itVAsNX8MDEgWEexD3b/JnQT3GcIQbpZUHJ6ZW13WIqUPaLlGU7CahoOgCF+RRy1+ZkXZq8OuppYlkUDNXIbFIp02pKaaqk0MA+8IvUOk172vi9Pkl1J67qeu8NbGYBrWMtqro0uAWBLMkATrg+bqEEQxA5LdgQ/a1kEts8XQ==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 05 Feb 2021 13:50:45 +0000
- Ironport-sdr: Bo0BH94Zb51Hc7PNx3YhCiVHF/sQRlrD0lPX4ork/NYFPzd1GOIxPakuFElumDti33cZpsMDay a8bHUewKjyRTUj5rPv1n6LMucNKgR4u2ctPVrV+PGGZD5TUj58GVMJe3t7yK7e4XYiNnB4Qr7W SbSf5i1B5XhaKKijWazsVpke+bsoGW1SVJWeEQYtEdEm4VCkjF7lvAHo+2WavX2gzPtb0gDDXN CH6mx2bYrqEdAWqzIxTAJ5ACrBSIgX0Z/CLvbhUXfe1l4Lr1EpZl8Gw0M1UKSujlRrbU/+Eiy8 JsY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/02/2021 13:39, Roger Pau Monné wrote:
> On Fri, Feb 05, 2021 at 01:34:20PM +0000, Andrew Cooper wrote:
>> On 05/02/2021 11:53, Roger Pau Monne wrote:
>>> Bison is now mandatory when the pvshim build is enabled in order to
>>> generate the Kconfig.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>> ---
>>> Please re-run autogen.sh after applying.
>>>
>>> Fallout from this patch can lead to broken configure script being
>>> generated or bison not detected correctly, but those will be cached
>>> quite quickly by the automated testing.
>> I think this can be simpler. Both flex and bison are mandatory libxlutil.
> No, we ship the output .c and .h files so that the user only needs to
> have bison/flex if it wants to modify the .l or .y files AFAICT?
I know that theory, but it is broken in practice because of `git
checkout` timestamps.
Also, the Makefile explicitly enforces the checks, so they are mandatory
in despite an attempt to ship the preprocessed form.
~Andrew
|
