[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15] tools/configure: add bison as mandatory
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Feb 2021 13:34:20 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w39XjvvEUDGdeFK3tqqzxUK/ZTF7bkWusYkQkq/7oYY=; b=djwy8Uo/StcbUdwQmxgXcR9N/IcfPi13q8DvmFV2zmEWvR7TBA5a19Q/4DWOzd5B1gAtu0LFT05LGbJjFnaFm0TJkwYBUDVkyJHSkzzgLYeQoaJ+u6h2zNsezkTo6lgfxlmEAedaOb+CEWpf2UcCPCIMqfmMUQAUAl8Cm+/vFOFwxvVDqG0QlrO8qwT+5CPbL5NKAh4VfdwVCEr4GDFN7pyqwDlETkyzqjn7iG7tCcAVIXVpzrI0LNQybN8E+cRDFcnICbLHjqHzAbxDwgSSuwrl1sHsFIFHqdLRFZRZnhntmvd6t+60L/fkIdxQuUNGl9V1baHrl0DeDS7ocpzZsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNJ7huA1a6nplKfgFrqt0Bl8uCiA963UseKd9q8WW9bsozKxsYh9mqqEMMOFzhhsAxoMRF0jRUSGdKxBOJ0Zf+Ag+fUMKJg2p78xXZPaCu0VaFDBw/gVhJBKa64HfiinHYAlOdRbiGqRyNLs6H2ZKr286qsL+Qufs6q50/rb8yZmejsix/XrVk1hjYI6Eru2ot88W5U2RHHv2ZU5zAidMufJn6VP6/RpfSKYocimWSt6v0Q3ZLsL6pcBzlD5Ueb66AFkTzwlxz44KkUSSxQivsB/0MdSubeJFqGEwvjsivasa6pBcC5nJ3dXsQXXILxasuNHHRNkqPgPmXUMZTPLPw==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 05 Feb 2021 13:34:54 +0000
- Ironport-sdr: FCC/PQIU0BVIaRjc6Gj1k9uZuO7cMgHNuVXexHJUqqQXbZxtsXAKSHeVepDPmD4lT8U1wTb0Zy OykHw+K9+lu1LEgbR8RWP2RBm8y8nivzlDyUjyST5PmIXAicuv2BMRfvdfGNwyhGJAlIIXt7jv vmr8h2JCUBnw0HUiNuiFVLUMb1GrK3ILXI8d2b1/kUf77tZcYjhYTJDWkUokR9GFdEdvU6H0Wz UpAHs8plrMIjI2e6KFEQHkcfOgvwehXwyHXNiRaO4UTWGoCHks1nhq/QjYwcDVgRKW/C2C4EfV S/s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/02/2021 11:53, Roger Pau Monne wrote:
> Bison is now mandatory when the pvshim build is enabled in order to
> generate the Kconfig.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Please re-run autogen.sh after applying.
>
> Fallout from this patch can lead to broken configure script being
> generated or bison not detected correctly, but those will be cached
> quite quickly by the automated testing.
I think this can be simpler. Both flex and bison are mandatory libxlutil.
i.e. they should both simply to convert to _OR_FAIL variants in place.
~Andrew
> ---
> tools/configure.ac | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 5b328700e0..f4e3fccdb0 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -308,7 +308,6 @@ AC_ARG_VAR([AWK], [Path to awk tool])
> AC_PROG_CC
> AC_PROG_MAKE_SET
> AC_PROG_INSTALL
> -AC_PATH_PROG([BISON], [bison])
> AC_PATH_PROG([FLEX], [flex])
> AX_PATH_PROG_OR_FAIL([PERL], [perl])
> AX_PATH_PROG_OR_FAIL([AWK], [awk])
> @@ -516,5 +515,10 @@ AC_ARG_ENABLE([pvshim],
> esac
> ])
> AC_SUBST(pvshim)
> +AS_IF([test "x$pvshim" = "xy"], [
> + AX_PATH_PROG_OR_FAIL([BISON], [bison])
> +], [
> + AC_PATH_PROG([BISON], [bison])
> +])
>
> AC_OUTPUT()
|
