[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: mark parameters in stub functions as unused

  • To: Wei Liu <wl@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 14 Feb 2020 11:36:00 +0000
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen Development List <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Feb 2020 11:36:15 +0000
  • Ironport-sdr: NflRwFx/RrwozGcJOV8CXnjJXBMRdaaL1y4Acbd2iM47ffb2t7cB+EL6jnCQVhD2MaHlMOUz6R HjWY1VuoxVxGoQ8lyGMcopgMh1DNakWJ7QUYejIIt12CRKyvZK4wcbzHawmRxBsumzZ6nxeWl8 SrnR6Oz/u8aa7h8k7OTgCDlYrcNPJba9hwabvqP3oi9+2VfM30Z0eeH+/X0I8+PuX0rwx3aROl mC+HbQA6JRXmX1Y/5PK4pvQ8lmcu/DOh2CMunVC4oPoY3y7Q9WWD7OI0do2P25m+veR8aE+GWZ evo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Wei Liu writes ("Re: [PATCH] libxl: mark parameters in stub functions as 
> I have actually successfully compiled a C file written in a similar way
> and tried with / without -Wunused-paremeter. After adding the unused
> attribute gcc stopped spitting out a warning.

That sounds like a sufficient test to me.

> I don't have libvirt lying around though. That's what I didn't test.
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Thanks. I will push it shortly.

Great, thanks.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.