[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: mark parameters in stub functions as unused


  • To: Wei Liu <wl@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 14 Feb 2020 11:00:44 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen Development List <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Feb 2020 11:00:57 +0000
  • Ironport-sdr: iMXPVooOip1vShpFE9b9fKBIpJUvdNXuQPTBOQrZD8H27QpsxLiHsChG4xkQNnqTdyQlcQ1gRe o8JZUIl2MpxZMkUNmNloRGpbubZt+dm2FQ0wvGJAfjw6sSNC4ZDe5Us/6fP6uwvif5ZOIxq1NA eSWnZzXEKHODLmJyWm76g4O/GJRs2PyUtTULoNecSUQUGIl7WwTiCBLqgiytJeoXAjfK4UHBiJ zDDFyc0Xiov1Ly2nnlqI7rG7Pz3WvW8knVsXWB4EIRCD/xJlo9oMcTeK0nsI45mgVlnX2YPu9g txs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Wei Liu writes ("[PATCH] libxl: mark parameters in stub functions as unused"):
> Hopefully this can fix issues like:
> 
> In file included from ../../src/libxl/xen_xl.c:24:0:
> /home/osstest/build.147035.build-amd64-libvirt/xendist/usr/local/include/libxl.h:
>  In function 'libxl_cpuid_apply_policy':
> /home/osstest/build.147035.build-amd64-libvirt/xendist/usr/local/include/libxl.h:2345:56:
>  error: unused parameter 'ctx' [-Werror=unused-parameter]
>  static inline void libxl_cpuid_apply_policy(libxl_ctx *ctx, uint32_t domid) 
> {}
> 
> Fixes: dacb80f9 ("tools/libxl: Remove libxl_cpuid_{set,apply_policy}() from 
> the API")
> Signed-off-by: Wei Liu <wl@xxxxxxx>
> ---
> Not able to test this locally, please review carefully...

The syntax looks good to me.  I haven't compiled it.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.