Re: [Xen-devel] [PATCH] libxl: mark parameters in stub functions as unused

[Wei Liu <wl@xxxxxxx>]

On Fri, Feb 14, 2020 at 11:00:44AM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] libxl: mark parameters in stub functions as unused"):
> > Hopefully this can fix issues like:
> > 
> > In file included from ../../src/libxl/xen_xl.c:24:0:
> > /home/osstest/build.147035.build-amd64-libvirt/xendist/usr/local/include/libxl.h:
> >  In function 'libxl_cpuid_apply_policy':
> > /home/osstest/build.147035.build-amd64-libvirt/xendist/usr/local/include/libxl.h:2345:56:
> >  error: unused parameter 'ctx' [-Werror=unused-parameter]
> >  static inline void libxl_cpuid_apply_policy(libxl_ctx *ctx, uint32_t 
> > domid) {}
> > 
> > Fixes: dacb80f9 ("tools/libxl: Remove libxl_cpuid_{set,apply_policy}() from 
> > the API")
> > Signed-off-by: Wei Liu <wl@xxxxxxx>
> > ---
> > Not able to test this locally, please review carefully...
> 
> The syntax looks good to me.  I haven't compiled it.
> 

I have actually successfully compiled a C file written in a similar way
and tried with / without -Wunused-paremeter. After adding the unused
attribute gcc stopped spitting out a warning.

I don't have libvirt lying around though. That's what I didn't test.

> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks. I will push it shortly.

Wei.

> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel