Re: [Xen-devel] [PATCH] xen/kconfig: unify messages of options moved from command line to kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.07.16 at 17:45, <roger.pau@xxxxxxxxxx> wrote:
> Change the message so that it mentions running from the top level directory
> and using '-C xen' in order to call the 'menuconfig' target inside of the
> xen directory (there's no top-level menuconfig target).

Well, I'm not convinced whether this end up clarifying or confusing
things, as that partly depends on how you normally invoke make (or
the various makes of the sub-trees individually).

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -9,27 +9,31 @@ lto           ?= n
>  
>  include $(XEN_ROOT)/Config.mk
>  
> +error_str = "You must use '$(MAKE) -C xen menuconfig' from the top level 
> directory to enable/disable $(1) now."
> +error_msg = $(error $(error_str))
> +warning_msg = $(warning $(error_str))

In any event with the two given uses "error_str" is not an
appropriate name. How about "build-diag" or some such?

> +
>  
>  ifneq ($(origin crash_debug),undefined)

And please don't add a stray second blank line like this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel