Re: [Xen-devel] [PATCH] xen/kconfig: unify messages of options moved from command line to kconfig

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Mon, Aug 01, 2016 at 09:21:28AM -0600, Jan Beulich wrote:
> >>> On 26.07.16 at 17:45, <roger.pau@xxxxxxxxxx> wrote:
> > Change the message so that it mentions running from the top level directory
> > and using '-C xen' in order to call the 'menuconfig' target inside of the
> > xen directory (there's no top-level menuconfig target).
> 
> Well, I'm not convinced whether this end up clarifying or confusing
> things, as that partly depends on how you normally invoke make (or
> the various makes of the sub-trees individually).

Hm, and what about adding a top-level menuconfig target, does that sound any 
better?

TBH, I'm not specially thrilled either way, I just think the message is 
misleading, but I don't mind putting this aside if everyone else is fine 
with it.
 
> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -9,27 +9,31 @@ lto           ?= n
> >  
> >  include $(XEN_ROOT)/Config.mk
> >  
> > +error_str = "You must use '$(MAKE) -C xen menuconfig' from the top level 
> > directory to enable/disable $(1) now."
> > +error_msg = $(error $(error_str))
> > +warning_msg = $(warning $(error_str))
> 
> In any event with the two given uses "error_str" is not an
> appropriate name. How about "build-diag" or some such?
> 
> > +
> >  
> >  ifneq ($(origin crash_debug),undefined)
> 
> And please don't add a stray second blank line like this.

Ack to the above comments, but will wait for opinions before resending.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel