[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] symbols: Generate an xen-sym.map file similar to Linux's



>>> On 18.07.16 at 20:39, <konrad.wilk@xxxxxxxxxx> wrote:

First of all, for the title: Is what you do really similar to Linux? Iirc
there System.map is simply output from nm.

> Also note that during runtime one can do:
> ffff82d080104920 t domain.c#do_domain_pause

I can't seem to make sense of this.

> @@ -307,6 +308,12 @@ static void write_src(void)
>       unsigned int *markers;
>       char buf[KSYM_NAME_LEN+1];
>  
> +     if (skip_asm) {

Especially with its use here I don't think this is a good name. How
about using something that positively identifies what is being asked
for, like "map_only" or "dump_symbols"?

> +             for (i = 0; i < table_cnt; i++)
> +                     printf("%#llx %c %s\n", table[i].addr, table[i].type, 
> table[i].orig_symbol);

Long line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.