[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/8] x86/vm-event/monitor: turn monitor_write_data.do_write into enum



On 7/1/2016 9:53 AM, Razvan Cojocaru wrote:
On 06/30/16 21:44, Corneliu ZUZU wrote:
After trapping a control-register write vm-event and -until- deciding if that
write is to be permitted or not (VM_EVENT_FLAG_DENY) and doing the actual write,
there cannot and should not be another trapped control-register write event.
That is, currently -only one- of the fields of monitor_write_data.do_write can
be true at any given moment and therefore it would be more appropriate to
replace those fields with an enum value.

Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
---
  xen/arch/x86/hvm/hvm.c       | 18 +++++++++++-------
  xen/arch/x86/monitor.c       | 37 ++++++++++++++++++-------------------
  xen/arch/x86/vm_event.c      | 25 ++-----------------------
  xen/include/asm-x86/domain.h | 20 ++++++++++----------
  4 files changed, 41 insertions(+), 59 deletions(-)
I'm not sure why neither Tamas' or my email address are in the CC list
(I would have assumed either monitor.c or vm_event.c would trigger a
response from get_maintainters.pl). In any case:

Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>


Thanks,
Razvan


I only now notice, it seems there's a problem with MAINTAINERS, the 2 files are listed:
F:    xen/*/vm_event.c
F:    xen/*/monitor.c
there and the listing should have been:
F:    xen/arch/*/vm_event.c
F:    xen/arch/*/monitor.c

Will submit a separate patch ASAP with that adjustment.

Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.