Re: [Xen-devel] [PATCH 8/8] minor #include change

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 06/30/16 21:47, Corneliu ZUZU wrote:
> Move xen/paging.h #include from hvm/monitor.h to hvm/monitor.c (include 
> strictly
> where needed) and also change to asm/paging.h (include strictly what's 
> needed).
> 
> Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/monitor.c        | 1 +
>  xen/include/asm-x86/hvm/monitor.h | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
> index 472926c..d81b11b 100644
> --- a/xen/arch/x86/hvm/monitor.c
> +++ b/xen/arch/x86/hvm/monitor.c
> @@ -26,6 +26,7 @@
>  #include <asm/hvm/monitor.h>
>  #include <asm/monitor.h>
>  #include <asm/vm_event.h>
> +#include <asm/paging.h>
>  #include <public/vm_event.h>

If this #include is not required to be exactly where it is, I believe
alphabetical order is preferred (so #include <asm/paging.h> would be
above #include <asm/vm_event.h>).


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel