Re: [Xen-devel] [PATCH for-4.6] tools/libxc: linux: Don't use getpagesize() when unmapping the grants

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-08-07 at 22:45 +0100, Wei Liu wrote:
> On Fri, Aug 07, 2015 at 07:53:55PM +0100, Julien Grall wrote:
> > The grants are based on the Xen granularity (i.e 4KB). While the 
> > function
> > to map grants for Linux (linux_gnttab_grant_map) is using the correct
> > size (XC_PAGE_SIZE), the unmap one (linux_gnttab_munmap) is using
> > getpagesize().
> > 
> > On domain using a page granularity different than Xen (this is the case
> > for AARCH64 guest using 64KB page), the unmap will be called with the
> > wrong size.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> I think this is a bug fix and should be applied for 4.6.

Agreed.

WRT to backports for 4.5 I'd appreciate being given a full list of required
fixes once everything is in place and working for 4.6/devbranch rather than
my tracking it piecemeal.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel