[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.6] tools/libxc: linux: Don't use getpagesize() when unmapping the grants

On Fri, Aug 07, 2015 at 07:53:55PM +0100, Julien Grall wrote:
> The grants are based on the Xen granularity (i.e 4KB). While the function
> to map grants for Linux (linux_gnttab_grant_map) is using the correct
> size (XC_PAGE_SIZE), the unmap one (linux_gnttab_munmap) is using
> getpagesize().
> On domain using a page granularity different than Xen (this is the case
> for AARCH64 guest using 64KB page), the unmap will be called with the
> wrong size.
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I think this is a bug fix and should be applied for 4.6.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.