Re: [Xen-devel] [PATCH for-4.6] libxl: fix libxl__build_hvm error code return path

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Aug 11, 2015 at 01:44:45PM +0100, Ian Campbell wrote:
> On Tue, 2015-08-11 at 09:57 +0100, Wei Liu wrote:
> > On Fri, Aug 07, 2015 at 06:08:25PM +0200, Roger Pau Monne wrote:
> > > This is a simple fix to make sure libxl__build_hvm returns an error 
> > > code in
> > > case of failure.
> > > 
> > 
> > 
> > 
> > > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Unfortunately I think this will result in any valid rc's any path happens
> to have being discarded in favour of a generic ERROR_FAIL.
> 

Don't worry, this is the original behaviour.

> If we are going to band aid this for 4.6 then I think setting rc =
> ERROR_FAIL just after the libxl__domain_device_construct_rdm error handling
> might be better.
> 
> Even better would be to put the rc = ERROR_FAIL into the various if (ret)
> blocks. I don't think that would be an unacceptably large patch (it's 3-4
> sites from what I can see) and it would be closer to heading in the right
> direction.
> 

I can do this as well, since Roger is on vacation at the moment.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel