Re: [Xen-devel] [RFC PATCH V2 1/8] xen/mem_event: Cleanup of mem_event structures

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Jan 29, 2015 at 1:51 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 29.01.15 at 13:09, <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> The reason why compilation fails is because the new preprocessor check
>> in mem_event.j #if !defined(__XEN__) && !defined(__XEN_TOOLS__) is not
>> happy and I get the error message #error "vm event operations are
>> intended for use only by Xen or node control tools".
>
> Ah, it's the #error afterwards.
>
>> This is a new
>> addition into the mem_event.h thus the build without this
>> pre-processor check works just fine. All other headers within
>> include/public that have similar preprocessor checks are already
>> excluded in this line, thus my impression was this is the correct way
>> to get the build to progress. Of course if I missed something please
>> let me know, I don't honestly fully comprehend the build process here.
>
> Question is - do you really need this here? Is it completely beyond
> possibility that some event interaction may also be possible from
> the VM being subject of the event generation/handling? There are
> plenty examples of
>
> #if defined(__XEN__) || defined(__XEN_TOOLS__)
>
> in other than domctl.h/sysctl.h, and perhaps that's instead the way
> to go here?
>
> Jan

Sure, that would work if I wrap the entire header into that
#if/#endif. I can switch to that if preferred.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel