Re: [Xen-devel] [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-01-29 at 12:49 +0000, Ian Jackson wrote:
> $esrow is autovivified as { } by
>             $candrow->{EquivMostRecentStatus} = $esrow->{status}
> so use %$esrow which in scalar context is true iff the
> hash is nonempty.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I'll either push this ontop of the existing queue if that needs
restarting for some reason, or along with the libvirt stuff which we
discussed would go in next (along with your ap-push linux cleanups)

> ---
>  ts-hosts-allocate-Executive |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
> index 4d5e3bb..7a9411d 100755
> --- a/ts-hosts-allocate-Executive
> +++ b/ts-hosts-allocate-Executive
> @@ -372,7 +372,7 @@ END
>           $candrow->{EquivMostRecentStatus} = $esrow->{status};
>           print DEBUG "$dbg EQUIV-MOST-RECENT ";
>           print DEBUG ("$esrow->{flight}.$esrow->{job}".
> -                      " $esrow->{val} $esrow->{status}") if $esrow;
> +                      " $esrow->{val} $esrow->{status}") if %$esrow;
>           print DEBUG ".\n";
>       }
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel