Re: [Xen-devel] [PATCH] libxl: Actually append the "-vga none" parameter to qemu when using qemu-xen

[Sander Eikelenboom <linux@xxxxxxxxxxxxxx>]

Friday, January 23, 2015, 10:06:04 AM, you wrote:

> Il 22/01/2015 18:21, Sander Eikelenboom ha scritto:
>> Commit 2e5738ff "libxl: Add none to vga parameter" introduced the "none"
>> option for the Xen "vga=" config option but only appends the needed parameter
>> for the qemu-traditional case. This patch fixes the qemu-xen case by
>> appending the same "-vga none" qemu paramter.

> In upstream qemu -nodefaults is used, -vga none is old and deprecated 
> way and not needed with -nodefaults used:
> http://git.qemu.org/?p=qemu.git;a=blob;f=docs/qdev-device-use.txt;hb=HEAD
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/libxl/libxl_dm.c;hb=HEAD
>  
> (search -nodefaults)
> What exactly is your problem?
> Could you better detail?

> Thanks for any reply.

Ah you are right .. hmm it seems even this patch isn't helping ..

with vnc=0 && sdl=0 && vga=none i still end up with:
00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02)
00:01.0 ISA bridge: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II]
00:01.1 IDE interface: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II]
00:01.3 Bridge: Intel Corporation 82371AB/EB/MB PIIX4 ACPI (rev 03)
00:02.0 Unassigned class [ff80]: XenSource, Inc. Xen Platform Device (rev 01)
00:03.0 VGA compatible controller: Cirrus Logic GD 5446

A Cirrus logic controller ..

My assumption that sdl=0 disables sdl seems to be wrong .. i also needed the 
"nographic" option.

It seems you just have to be very persuasive to get rid of it :-)

So without this patch and with sdl=0 && vnc=0 && vga=none && nographic=1 .. 
i finely did get rid of the cirrus logic controller.



I'm not entirely sure the "-nodefaults" actually works .. since xen uses it's 
own machine type "xenfv" by default .. and the referenced doc says:

    292 The new way is -device.  The mapping from -vga argument to -device
    293 depends on the machine type.  For machine "pc", it's:
    <snip>
    315 Bug: the new way doesn't work for machine types "pc" and "isapc",
    316 because it violates obscure device initialization ordering
    317 constraints.

And further on the document says:

   395 === Default Devices ===
   396
   397 QEMU creates a number of devices by default, depending on the machine
   398 type.
   399
   400 -device DEVNAME... and global DEVNAME... suppress default devices for
   401 some DEVNAMEs:
   402
   403     default device      suppressing DEVNAMEs
   404     CD-ROM              ide-cd, ide-drive, scsi-cd
   405     isa-fdc's driveA    isa-fdc
   406     parallel            isa-parallel
   407     serial              isa-serial
   408     VGA                 VGA, cirrus-vga, vmware-svga
   409     virtioconsole       virtio-serial-pci, virtio-serial-s390, 
virtio-serial
   410
   411 The default NIC is connected to a default part created along with it.
   412 It is *not* suppressed by configuring a NIC with -device (you may call
   413 that a bug).  -net and -netdev suppress the default NIC.
   414
   415 -nodefaults suppresses all the default devices mentioned above, plus a
   416 few other things such as default SD-Card drive and default monitor.

It doesn't say any thing explicitly about sdl though, so it's either:

- the no-defaults also works for machine="xenfv", but qemu still defaults to 
sdl .. and therefore still enables the cirrus logic
  controller (or the referenced document is wrong)
or
- the no-defaults doesn't seem to work for machine="xenfv"

Will see if i can figure out which of the two it is ..

--
Sander







>>
>> Signed-off-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
>> ---
>>   tools/libxl/libxl_dm.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index c2b0487..fc3f5a7 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -589,6 +589,7 @@ static char ** 
>> libxl__build_device_model_args_new(libxl__gc *gc,
>>                   libxl__sizekb_to_mb(b_info->video_memkb)));
>>               break;
>>           case LIBXL_VGA_INTERFACE_TYPE_NONE:
>> +            flexarray_append_pair(dm_args, "-vga", "none");
>>               break;
>>           }
>>   




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel