Re: [Xen-devel] [PATCH] libxl: Actually append the "-vga none" parameter to qemu when using qemu-xen

[Fabio Fantoni <fabio.fantoni@xxxxxxx>]

Il 22/01/2015 18:21, Sander Eikelenboom ha scritto:
> Commit 2e5738ff "libxl: Add none to vga parameter" introduced the "none"
> option for the Xen "vga=" config option but only appends the needed parameter
> for the qemu-traditional case. This patch fixes the qemu-xen case by
> appending the same "-vga none" qemu paramter.
In upstream qemu -nodefaults is used, -vga none is old and deprecated 
way and not needed with -nodefaults used:
http://git.qemu.org/?p=qemu.git;a=blob;f=docs/qdev-device-use.txt;hb=HEAD
http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/libxl/libxl_dm.c;hb=HEAD 
(search -nodefaults)
What exactly is your problem?
Could you better detail?

Thanks for any reply.

> Signed-off-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> ---
>   tools/libxl/libxl_dm.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index c2b0487..fc3f5a7 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -589,6 +589,7 @@ static char ** libxl__build_device_model_args_new(libxl__gc 
> *gc,
>                   libxl__sizekb_to_mb(b_info->video_memkb)));
>               break;
>           case LIBXL_VGA_INTERFACE_TYPE_NONE:
> +            flexarray_append_pair(dm_args, "-vga", "none");
>               break;
>           }
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel