[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 0/5] arm/early-printk: Improve reusability and add Calxeda support

On 05/30/2013 10:59 AM, Ian Campbell wrote:
On Fri, 2013-05-24 at 15:47 +0200, Andre Przywara wrote:
The current early-printk support for ARM is rather hard-coded, making
it hard to add machines or tweak settings.
This series slightly moves some code to gather UART settings in
xen/arch/arm/Rules.mk instead of the actual .c files. Also it allows
two different machines with different settings to share the same
driver, which the last patch exploits to add support the Calxeda
Midway hardware.

This haven't been extensively tested, but I looked at the generated
assembly and did some quick checks on Versatile Express.

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxxx>

All Acked + applied, thanks.


I did wonder vaguely about:

pulling the per board configs out of Rules.mk into
earlyprintk-<board>.mk and doing:
         include earlyprintk-$(CONFIG_EARLY_PRINTK).mk

Yeah, I also found it being in kind of the wrong place.
Just wasn't sure if early_printk justifies <n> extra files to be created. What about moving all the boards definitions into one file and including this? This keeps Rules.mk clean and avoids too much clutter.


using the presence or absence of EARLY_PRINTK_BAUD instead of using a

I was also wondering about this redundancy, this seems to be a nice solution for this. Thanks, will make a patch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.