Re: [Xen-devel] [PATCH v2 0/5] arm/early-printk: Improve reusability and add Calxeda support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-24 at 15:47 +0200, Andre Przywara wrote:
> The current early-printk support for ARM is rather hard-coded, making
> it hard to add machines or tweak settings.
> This series slightly moves some code to gather UART settings in
> xen/arch/arm/Rules.mk instead of the actual .c files. Also it allows
> two different machines with different settings to share the same
> driver, which the last patch exploits to add support the Calxeda
> Midway hardware.
> 
> This haven't been extensively tested, but I looked at the generated
> assembly and did some quick checks on Versatile Express.
> 
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxxxxxx>

All Acked + applied, thanks.

I did wonder vaguely about:

pulling the per board configs out of Rules.mk into
earlyprintk-<board>.mk and doing:
        ifneq($(CONFIG_EARLY_PRINTK),)
        include earlyprintk-$(CONFIG_EARLY_PRINTK).mk
        endif

and

using the presence or absence of EARLY_PRINTK_BAUD instead of using a
separate EARLY_PRINTK_INIT_UART.

Neither of which affect the correctness of this series though.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel