[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/20] PVH xen: add XENMEM_add_to_physmap_range

>>> On 16.05.13 at 13:03, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
> On Thu, 16 May 2013, Jan Beulich wrote:
>> >>> On 16.05.13 at 01:05, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
>> >+        xatp.space = xatpr->space;
>> >+        xatp.idx = idx;
>> >+        xatp.gpfn = gpfn;
>> >+        rc = xenmem_add_to_physmap_once(d, &xatp, xatpr->foreign_domid);
>> xatp has a domid field - why don't you use that instead of adding a
>> new function parameter? I'm unclear anyway why two domain IDs
>> are useful here at all - Ian, Stefano, for one I still can't spot any use
>> of xen_add_to_physmap_range in tools and qemu (and hence can't
>> see a clear use case), and then I doubt there's real use for one
>> domain mapping GFNs from a second domain into a third one. If it's
>> really dead code that got added here, shouldn't we drop it now
>> rather than releasing 4.3 with it baked into the interface?
> We use XENMEM_add_to_physmap_range to map foreign mfns in dom0 during
> domain creation.

Hmm - for one, where is that code? And then - this involves only
two domains, but the interface explicitly permits for three, and
that aspect was what my query was about.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.