[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 02/20] PVH xen: add XENMEM_add_to_physmap_range

>>> On 15.05.13 at 02:52, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -4519,7 +4519,8 @@ static int handle_iomem_range(unsigned long s, unsigned 
> long e, void *p)
>  static int xenmem_add_to_physmap_once(
>      struct domain *d,
> -    const struct xen_add_to_physmap *xatp)
> +    const struct xen_add_to_physmap *xatp,
> +    domid_t foreign_domid)
>  {
>      struct page_info *page = NULL;
>      unsigned long gfn = 0; /* gcc ... */
> @@ -4646,7 +4647,7 @@ static int xenmem_add_to_physmap(struct domain *d,

I know I said this before: This patch can't be complete, or else the
new function parameter would actually get used. With the way
things are, if this patch gets applied, a user of the new XENMEM_
sub-op would not get the expected behavior.

And I know I said this before too: It should be possible to apply
any contiguous initial sub-portion of a patch series without
introducing breakage to the tree - you shouldn't assume the
whole series gets applied in one go (or, if found necessary later,
gets reverted altogether).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.