Re: [Xen-devel] dump with xen-unstable & linux 3.2.17

[Ben Guthro <ben@xxxxxxxxxx>]

On Thu, May 31, 2012 at 12:06 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 31.05.12 at 17:52, Ben Guthro <ben@xxxxxxxxxx> wrote:
>> 1. The changeset mentioned below needed to be reverted, as it was
>> removing the CPUS at suspend time.
>
> I assume you refer to the one line change, not the full c/s?
> Juergen would have to tell us whether reverting that would
> break something else.

I reverted the whole c/s - but I think the one line change would be sufficient.

>
>> 2. The linux xen watchdog driver (drivers/watchdog/xen_wdt.c) seems to
>> be enabling itsself on resume, even if you tell it not to.
>> I worked around this by just turning off watchdogs in my kernel
>> config...because I wasn't using them anyhow.
>
> That was a problem up to 3.3, but was fixed in 3.4 afaict. What
> kernel version did you see this with?
>

3.2.17 + some of konrad's branches
...so that makes sense.


> Jan
>
>> On Fri, May 25, 2012 at 9:20 AM, Ben Guthro <ben@xxxxxxxxxx> wrote:
>>> Changed parts:
>>>
>>> diff --git a/xen/common/schedule.c b/xen/common/schedule.c
>>> index 0854f55..95cb2b4 100644
>>> --- a/xen/common/schedule.c
>>> +++ b/xen/common/schedule.c
>>> @@ -543,7 +543,7 @@ int cpu_disable_scheduler(unsigned int cpu)
>>>     int    ret = 0;
>>>
>>>     c = per_cpu(cpupool, cpu);
>>> -    if ( (c == NULL) || (system_state == SYS_STATE_suspend) )
>>> +    if ( (c == NULL) )
>>>         return ret;
>>>
>>>     for_each_domain_in_cpupool ( d, c )
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel