[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 4/4] tools/build: change order of config/Tools.mk inclusion

Christoph Egger wrote:
On 05/18/12 15:30, Ian Jackson wrote:

Roger Pau Monne writes ("Re: [PATCH v2 4/4] tools/build: change order of 
config/Tools.mk inclusion"):
Ian Jackson wrote:
I know that.  But given that the configure is just for the tools
build, should we honour PREFIX from Config.mk (and ./.config or
command line arguments) or from ./configure ?
I think the one from configure, since we have a configure script, better
make use of it, that is what users expect.
I guess so.

I will resend this patch with the above changes to config/Linux.mk,
is that ok?
I don't think prefixing paths in /var with PREFIX is ever right.
Overriding it in Linux.mk seems like a band-aid.

One suggestion:

Move all path variables out of config/*.mk and let configure generate
a config/paths.mk.

What should we do about this? Should I try to fix StdGNU.mk/Linux.mk/NetBSD.mk or are we going to move all paths from config/*.mk and put them in a single file generated by configure?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.