Re: [Xen-devel] [PATCH v2 4/4] tools/build: change order of config/Tools.mk inclusion

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On 05/18/12 15:30, Ian Jackson wrote:

> Roger Pau Monne writes ("Re: [PATCH v2 4/4] tools/build: change order of 
> config/Tools.mk inclusion"):
>> Ian Jackson wrote:
>>> I know that.  But given that the configure is just for the tools
>>> build, should we honour PREFIX from Config.mk (and ./.config or
>>> command line arguments) or from ./configure ?
>>
>> I think the one from configure, since we have a configure script, better 
>> make use of it, that is what users expect.
> 
> I guess so.
> 
>> I will resend this patch with the above changes to config/Linux.mk,
>> is that ok?
> 
> I don't think prefixing paths in /var with PREFIX is ever right.
> Overriding it in Linux.mk seems like a band-aid.


One suggestion:

Move all path variables out of config/*.mk and let configure generate
a config/paths.mk.

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel