Re: [Xen-devel] [PATCH v5 7/8] xl/libxl: implement QDISK libxl_device_disk_local_attach

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 14 May 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH v5 7/8] xl/libxl: implement QDISK 
> libxl_device_disk_local_attach"):
> > On Mon, 14 May 2012, Ian Jackson wrote:
> > > I think you should s/rc/<something else>/ when it's the return value
> > > from xs_*.  ret would do.  If rc is used for a libxl error code it
> > > should remain as rc.
> > 
> > rc is already used for a libxl error code in the same function.
> > Maybe I should just add ret in addition to rc?
> 
> I think that would be better.  Do you agree ?

In general I try to make my code as easy to read as possible. A new
integer is a small price to pay for it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel