Re: [Xen-devel] [PATCH v5 7/8] xl/libxl: implement QDISK libxl_device_disk_local_attach

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 14 May 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [PATCH v5 7/8] xl/libxl: implement QDISK 
> libxl_device_disk_local_attach"):
> > On Fri, 4 May 2012, Ian Jackson wrote:
> > > Maybe I'm being excessively picky, but I think "rc" should be used
> > > only for a variable which contains libxl error codes.  I had to do a
> > > double-take when I saw
> > >   if (rc == 0) {
> > >      error handling;
> > > since rc==0 is of course the success case.
> > 
> > Should I s/rc/ret/ in this function?
> 
> I think you should s/rc/<something else>/ when it's the return value
> from xs_*.  ret would do.  If rc is used for a libxl error code it
> should remain as rc.

rc is already used for a libxl error code in the same function.
Maybe I should just add ret in addition to rc?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel