[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 7/8] xl/libxl: implement QDISK libxl_device_disk_local_attach

Stefano Stabellini writes ("Re: [PATCH v5 7/8] xl/libxl: implement QDISK 
> On Mon, 14 May 2012, Ian Jackson wrote:
> > I think you should s/rc/<something else>/ when it's the return value
> > from xs_*.  ret would do.  If rc is used for a libxl error code it
> > should remain as rc.
> rc is already used for a libxl error code in the same function.
> Maybe I should just add ret in addition to rc?

I think that would be better.  Do you agree ?

As I say this seems like quite a small nit I'm picking.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.