[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP client

  • To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Mon, 27 Jun 2011 18:04:48 +0100
  • Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • Delivery-date: Mon, 27 Jun 2011 10:07:29 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=lvXYuRfPPrATtKiWEnPhkDSDAqlHxo7MswrKd4eumF1unMJKDJCYO/Qt7Xblqrn/ls UWbF1PsEQoOAhyEoyxx9xsLSF61H5qvte6Jqg5guoKOe+BzEqkKe6gWX/q4F0g3MQXz1 vsaOqkTx6vT47K/VUreNNw3qbuCgotveTSx/4=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On Mon, Jun 27, 2011 at 17:17, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Anthony PERARD writes ("[Xen-devel] [PATCH V5 3/3] libxl, Introduce a QMP 
> client"):
>> QMP stands for QEMU Monitor Protocol and it is used to query information
>> from QEMU or to control QEMU.
>> This implementation will ask QEMU the list of chardevice and store the
>> path to serial0 in xenstored. So we will be able to use xl console with
>> QEMU upstream.
> Can I make a suggestion ? ÂI think the formulaic json parser stuff
> could usefully live in a separate file.

Ok, I will cut the file.

>> +static inline yajl_gen_status yajl_gen_asciiz(yajl_gen hand, const
> char *str)
> Isn't this a hostage to fortune ? Âyajl may grow an identically-named
> function in which case this will no longer build.

Maybe. I will rename to libxl__yajl_gen_asciiz.

>> +#ifdef DEBUG_ANSWER
>> + Â Âif (qmp->g)
>> + Â Â Â Âyajl_gen_free(qmp->g);
>> +#endif
> Can this #ifdef not be shuffled off somewhere ? ÂIe, make a debug
> function (or macro) which we call unconditionally.

Ok, I will remove all the #ifdef debug_answer.

> The rest looks plausible.

Thanks for the review,

Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.