[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] Re: [PATCH] qemu_ram_ptr_length: take ram_addr_t as arguments
On 27 June 2011 14:34, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote: > On Fri, 24 Jun 2011, Peter Maydell wrote: >> You probably want to only call qemu_ram_ptr_length() if (todo). >> (I don't know if anybody ever calls this routine with a zero input >> length, but that would handle that case too.) > > I would rather fix qemu_ram_ptr_length to handle 0 as size argument, and > then call qemu_ram_ptr_length with 0 size from cpu_physical_memory_map > (see appended patch). OK, that should work too. >> (Also 'addr1' is not a fantastic variable name :-)) > > Agreed, but it is the same as before :) > Do you have any better suggestion? Maybe raddr? I admit I am not very > imaginative with names. I think raddr is better than addr1, yes. > + Â Âif (*size == 0) > + Â Â Â Âreturn NULL; Incidentally, QEMU coding style has braces here. scripts/checkpatch.pl can catch this kind of minor style nit for you (although it is not infallible...) -- PMM _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |