[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2 of 4] fix not functional eval

To: Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 21 Jun 2011 17:44:55 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Jun 2011 09:45:25 -0700
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Zhigang Wang writes ("[Xen-devel] [PATCH 2 of 4] fix not functional eval"):
> fix not functional eval
> 
> I don't understand why use eval here. It doesn't work and the case syntax
> seems not right.

You are right that the case syntax is wrong.  But the eval is needed
because
  case "$name" in
  $NAMES)
doesn't look into $NAMES to see the |s.

The existing script is a perfectly hideous piece of code.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

References:
- [Xen-devel] [PATCH 0 of 4] fix xendomains service
  - From: Zhigang Wang
- [Xen-devel] [PATCH 2 of 4] fix not functional eval
  - From: Zhigang Wang

Prev by Date: Re: [Xen-devel] Domains not being destroyed properly
Next by Date: Re: [Xen-devel] [PATCH RESENTv2] libxl: add all pci devices to xenstore at once (during VM create)
Previous by thread: [Xen-devel] [PATCH 2 of 4] fix not functional eval
Next by thread: [Xen-devel] [PATCH 3 of 4] make xendomains service save/migrate vms under /etc/xen/auto only
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.