[Xen-devel] [PATCH 2 of 4] fix not functional eval

[Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>]

# HG changeset patch
# User Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>
# Date 1307569509 14400
# Node ID 4982815ee816edd44a85c27e885437cfcd227612
# Parent  be4f09fff517c1973d643635c9f40574a693da1a
fix not functional eval

I don't understand why use eval here. It doesn't work and the case syntax
seems not right.

Remove the eval and fix the case syntax works fine.

Signed-off-by: Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>

diff -r be4f09fff517 -r 4982815ee816 tools/hotplug/Linux/init.d/xendomains
--- a/tools/hotplug/Linux/init.d/xendomains     Wed Jun 08 17:44:36 2011 -0400
+++ b/tools/hotplug/Linux/init.d/xendomains     Wed Jun 08 17:45:09 2011 -0400
@@ -365,17 +365,15 @@ stop()
        if test $id = 0; then continue; fi
        echo -n " $name"
        if test "$XENDOMAINS_AUTO_ONLY" = "true"; then
-           eval "
-           case \"\$name\" in
-               ($NAMES)
+           case "$name" in
+               $NAMES)
                    # nothing
                    ;;
-               (*)
+               *)
                    echo -e '(skip)'
                    continue
                    ;;
            esac
-           "
        fi
        # XENDOMAINS_SYSRQ chould be something like just "s" 
        # or "s e i u" or even "s e s i u o"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel