[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] libxl_cdrom_insert



On Fri, 2011-01-14 at 22:37 +0000, Kamala Narasimhan wrote: 
> Do we know the rationale behind setting disk->physpath to "" in the
> below code in libxl?  Hopefully there is more to it than to avoid a
> potential null pointer crash at a later point :)

I think it might indicate an empty CDROM drive in the HVM case. Arguably
a PHYSTYPE_EMPTY/NONE or some such concept might have been clearer. "hg
annotate" should lead you to the original commit.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.