Re: [Xen-devel] libxl_cdrom_insert

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Sat, 15 Jan 2011, Ian Campbell wrote:
> On Fri, 2011-01-14 at 22:37 +0000, Kamala Narasimhan wrote: 
> > Do we know the rationale behind setting disk->physpath to "" in the
> > below code in libxl?  Hopefully there is more to it than to avoid a
> > potential null pointer crash at a later point :)
> 
> I think it might indicate an empty CDROM drive in the HVM case. Arguably
> a PHYSTYPE_EMPTY/NONE or some such concept might have been clearer. "hg
> annotate" should lead you to the original commit.
> 

Yes, that is what it means: libxl callers set physpath to NULL to eject
a cdrom, however libxl_device_disk_add cannot handle NULL physpath's.
I think we should introduce PHYSTYPE_EMPTY and start using it in
libxl.c:libxl_event_get_disk_eject_info and xl_cmdimpl.c:cd_insert.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel