[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] VMX device models not getting created anymore?



Ian Pratt wrote:
 > http://xen.bkbits.net:8080/xeno-unstable.bk/cset@42a47555156iG

oOjUyZtvbuMFZHXkg

seems to have removed the call to creating device models.

@@ -773,43 +680,6 @@
                 ctrl.initController(reboot=True)
         else:
             self.create_configured_devices()
-        if self.is_vmx:
-            self.create_vmx_model()

I didn't see equivalent code getting added anywhere else.

The code got moved into createDeviceModel in VmxImageHandler
in image.py, but it looks like the call to createDeviceModel got
lost. It should go at the end of create_devices in XendDomainInfo:

    def create_devices(self):
        """Create the devices for a vm.

        @raise: VmError for invalid devices
        """
        if self.rebooting():
            for ctrl in self.getDeviceControllers():
                ctrl.initController(reboot=True)
        else:
            self.create_configured_devices()
        self.image.createDeviceModel()


Yep, I just sync'ed my VT tree up to the head to get a couple of your
fixes, and inherited this breakage as well. There's been loads of
changes to xend to move its database over to xenstore, but I don't think
its going to be hard to fix up.
I'm not going to get a chance to look at it before Monday evening
though.

Best,
Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.