[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 06/11] xenvkbd: Annotate remaining unannotated parameters


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 19 Oct 2026 15:14:32 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 19 Oct 2026 13:14:53 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

FdoScan, HidAcquire, RegistryAnsiToSz and RegistryAnsiToMultiSz had
pointer parameters with no SAL annotation. They are only read, so
annotate them _In_, as the same functions are annotated in xenvif.
No functional change.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvkbd/fdo.c      | 4 ++--
 src/xenvkbd/hid.c      | 2 +-
 src/xenvkbd/registry.c | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/xenvkbd/fdo.c b/src/xenvkbd/fdo.c
index c1c6e74..481336c 100644
--- a/src/xenvkbd/fdo.c
+++ b/src/xenvkbd/fdo.c
@@ -898,8 +898,8 @@ __FdoFreeAnsi(
 
 static NTSTATUS
 FdoScan(
-    PXENVKBD_THREAD     Self,
-    PVOID               Context
+    _In_ PXENVKBD_THREAD Self,
+    _In_ PVOID           Context
     )
 {
     PXENVKBD_FDO        Fdo = Context;
diff --git a/src/xenvkbd/hid.c b/src/xenvkbd/hid.c
index bfb16a6..4e90ac7 100644
--- a/src/xenvkbd/hid.c
+++ b/src/xenvkbd/hid.c
@@ -517,7 +517,7 @@ done:
 
 static NTSTATUS
 HidAcquire(
-    PINTERFACE              Interface
+    _In_ PINTERFACE         Interface
     )
 {
     PXENVKBD_HID_CONTEXT    Context = Interface->Context;
diff --git a/src/xenvkbd/registry.c b/src/xenvkbd/registry.c
index 2e82bcc..c488fc6 100644
--- a/src/xenvkbd/registry.c
+++ b/src/xenvkbd/registry.c
@@ -1430,7 +1430,7 @@ fail1:
 
 static PKEY_VALUE_PARTIAL_INFORMATION
 RegistryAnsiToSz(
-    PANSI_STRING                    Ansi
+    _In_ PANSI_STRING               Ansi
     )
 {
     ULONG                           Length;
@@ -1476,7 +1476,7 @@ fail1:
 
 static PKEY_VALUE_PARTIAL_INFORMATION
 RegistryAnsiToMultiSz(
-    PANSI_STRING                    Ansi
+    _In_ PANSI_STRING               Ansi
     )
 {
     ULONG                           Length;
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.