[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 00/11] xenvkbd: Update annotations to SAL 2.0


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 19 Oct 2026 15:12:45 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 19 Oct 2026 13:12:58 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

This patch series updates the xenvkbd driver to use SAL 2.0
annotations and fixes the issues found after code analysis.

It is organized into three parts: sync common files with xenbus, 
update annotations to SAL 2.0, and fix issues found after code analysis.

Part 1: Sync common files with xenbus
* xenvkbd: sync common files with xenbus
* registry: sync with xenbus
* xenvkbd: sync xenhid interface

Part 2: Update annotations to SAL 2.0
* xenvkbd: convert annotations to SAL 2.0
* xenvkbd: Update string typedefs
* xenvkbd: Annotate remaining unannotated parameters
* xenvkbd: Annotate modified parameters as _Out_ or _Inout_
* xenvkbd: Add size annotations to buffer parameters

Part 3: Fix issues found after code analysis
* xenvkbd: Fix annotations reported by code analysis
* driver: fix inconsistent annotation
* xenvkbd: Add an ASSERT on the array bound in SetArray

Césaire Mounah (11):
  xenvkbd: sync common files with xenbus
  registry: sync with xenbus
  xenvkbd: sync xenhid interface
  xenvkbd: convert annotations to SAL 2.0
  xenvkbd: Update string typedefs
  xenvkbd: Annotate remaining unannotated parameters
  xenvkbd: Annotate modified parameters as _Out_ or _Inout_
  xenvkbd: Add size annotations to buffer parameters
  xenvkbd: Fix annotations reported by code analysis
  driver: fix inconsistent annotation
  xenvkbd: Add an ASSERT on the array bound in SetArray

 include/cache_interface.h     | 130 ++++-----
 include/debug_interface.h     |  88 +++---
 include/evtchn_interface.h    | 136 +++++-----
 include/gnttab_interface.h    | 148 +++++------
 include/hid_interface.h       | 108 ++++----
 include/range_set_interface.h | 100 +++----
 include/store_interface.h     | 156 +++++------
 include/suspend_interface.h   |  80 +++---
 src/xenvkbd/assert.h          |  82 +++---
 src/xenvkbd/bus.c             |  68 ++---
 src/xenvkbd/bus.h             |   6 +-
 src/xenvkbd/dbg_print.h       |  34 +--
 src/xenvkbd/driver.c          |  31 +--
 src/xenvkbd/fdo.c             | 486 +++++++++++++++++-----------------
 src/xenvkbd/fdo.h             |  70 ++---
 src/xenvkbd/frontend.c        | 132 ++++-----
 src/xenvkbd/frontend.h        |  28 +-
 src/xenvkbd/hid.c             | 144 +++++-----
 src/xenvkbd/hid.h             |  20 +-
 src/xenvkbd/mrsw.h            |  24 +-
 src/xenvkbd/mutex.h           |  10 +-
 src/xenvkbd/names.h           |  24 +-
 src/xenvkbd/pdo.c             | 334 +++++++++++------------
 src/xenvkbd/pdo.h             |  76 +++---
 src/xenvkbd/registry.c        | 418 +++++++++++++++++++----------
 src/xenvkbd/registry.h        | 130 ++++-----
 src/xenvkbd/ring.c            | 136 +++++-----
 src/xenvkbd/ring.h            |  32 +--
 src/xenvkbd/thread.c          |  34 +--
 src/xenvkbd/thread.h          |  18 +-
 src/xenvkbd/util.h            |  87 +++---
 31 files changed, 1750 insertions(+), 1620 deletions(-)

-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.