[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 05/11] xenvkbd: Update string typedefs


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 19 Oct 2026 15:14:31 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 19 Oct 2026 13:14:53 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Mechanical pass, no functional change.

Types:
  const CHAR */CHAR * -> PCSTR/PSTR
  const WCHAR /WCHAR -> PCWSTR
  const PCHAR -> PCSTR
  PCHAR -> PSTR

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvkbd/fdo.c      |  4 ++--
 src/xenvkbd/pdo.c      |  6 +++---
 src/xenvkbd/pdo.h      |  2 +-
 src/xenvkbd/registry.c | 22 +++++++++++-----------
 src/xenvkbd/registry.h | 20 ++++++++++----------
 5 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/src/xenvkbd/fdo.c b/src/xenvkbd/fdo.c
index 3348862..c1c6e74 100644
--- a/src/xenvkbd/fdo.c
+++ b/src/xenvkbd/fdo.c
@@ -820,7 +820,7 @@ done:
 
 static FORCEINLINE PANSI_STRING
 __FdoMultiSzToUpcaseAnsi(
-    _In_ PCHAR      Buffer
+    _In_ PSTR       Buffer
     )
 {
     PANSI_STRING    Ansi;
@@ -1071,7 +1071,7 @@ FdoParseResources(
 static FORCEINLINE BOOLEAN
 __FdoMatchDistribution(
     _In_ PXENVKBD_FDO   Fdo,
-    _In_ PCHAR          Buffer
+    _In_ PSTR           Buffer
     )
 {
     PCHAR               Vendor;
diff --git a/src/xenvkbd/pdo.c b/src/xenvkbd/pdo.c
index 5572836..5443119 100644
--- a/src/xenvkbd/pdo.c
+++ b/src/xenvkbd/pdo.c
@@ -200,7 +200,7 @@ __PdoGetDevicePowerState(
 static FORCEINLINE VOID
 __PdoSetMissing(
     _In_ PXENVKBD_PDO   Pdo,
-    _In_ const CHAR     *Reason
+    _In_ PCSTR          Reason
     )
 {
     Pdo->Reason = Reason;
@@ -210,7 +210,7 @@ __PdoSetMissing(
 VOID
 PdoSetMissing(
     _In_ PXENVKBD_PDO   Pdo,
-    _In_ const CHAR     *Reason
+    _In_ PCSTR          Reason
     )
 {
     __PdoSetMissing(Pdo, Reason);
@@ -251,7 +251,7 @@ PdoGetFdo(
 static FORCEINLINE VOID
 __PdoSetName(
     _In_ PXENVKBD_PDO   Pdo,
-    _In_ PCHAR          Path
+    _In_ PSTR           Path
     )
 {
     PXENVKBD_DX         Dx = Pdo->Dx;
diff --git a/src/xenvkbd/pdo.h b/src/xenvkbd/pdo.h
index 09f7619..1df1fc2 100644
--- a/src/xenvkbd/pdo.h
+++ b/src/xenvkbd/pdo.h
@@ -53,7 +53,7 @@ PdoGetDevicePnpState(
 extern VOID
 PdoSetMissing(
     _In_ PXENVKBD_PDO   Pdo,
-    _In_ const CHAR     *Reason
+    _In_ PCSTR          Reason
     );
 
 extern BOOLEAN
diff --git a/src/xenvkbd/registry.c b/src/xenvkbd/registry.c
index e50cefc..2e82bcc 100644
--- a/src/xenvkbd/registry.c
+++ b/src/xenvkbd/registry.c
@@ -491,7 +491,7 @@ fail1:
 NTSTATUS
 RegistryDeleteSubKey(
     _In_ PHANDLE        Key,
-    _In_ PCHAR          Name
+    _In_ PSTR           Name
     )
 {
     ANSI_STRING         Ansi;
@@ -741,7 +741,7 @@ fail1:
 NTSTATUS
 RegistryDeleteValue(
     _In_ PHANDLE        Key,
-    _In_ PCHAR          Name
+    _In_ PSTR           Name
     )
 {
     ANSI_STRING         Ansi;
@@ -772,7 +772,7 @@ fail1:
 NTSTATUS
 RegistryQueryDwordValue(
     _In_ HANDLE                     Key,
-    _In_ PCHAR                      Name,
+    _In_ PSTR                       Name,
     _Out_ PULONG                    Value
     )
 {
@@ -912,7 +912,7 @@ fail1:
 NTSTATUS
 RegistryUpdateDwordValue(
     _In_ HANDLE                     Key,
-    _In_ PCHAR                      Name,
+    _In_ PSTR                       Name,
     _In_ ULONG                      Value
     )
 {
@@ -967,7 +967,7 @@ fail1:
 
 static PANSI_STRING
 RegistrySzToAnsi(
-    _In_ PWCHAR     Buffer
+    _In_ PWSTR      Buffer
     )
 {
     PANSI_STRING    Ansi;
@@ -1006,7 +1006,7 @@ fail1:
 
 static PANSI_STRING
 RegistryMultiSzToAnsi(
-    _In_ PWCHAR     Buffer
+    _In_ PWSTR      Buffer
     )
 {
     PANSI_STRING    Ansi;
@@ -1069,7 +1069,7 @@ fail1:
 NTSTATUS
 RegistryQuerySzValue(
     _In_ HANDLE                     Key,
-    _In_ PCHAR                      Name,
+    _In_ PSTR                       Name,
     _Out_opt_ PULONG                Type,
     _Outptr_ PANSI_STRING           *Array
     )
@@ -1156,7 +1156,7 @@ fail1:
 NTSTATUS
 RegistryQueryBinaryValue(
     _In_ HANDLE                     Key,
-    _In_ PCHAR                      Name,
+    _In_ PSTR                       Name,
     _Outptr_ PVOID                  *Buffer,
     _Out_ PULONG                    Length
     )
@@ -1241,7 +1241,7 @@ fail1:
 NTSTATUS
 RegistryUpdateBinaryValue(
     _In_ HANDLE                     Key,
-    _In_ PCHAR                      Name,
+    _In_ PSTR                       Name,
     _In_ PVOID                      Buffer,
     _In_ ULONG                      Length
     )
@@ -1352,7 +1352,7 @@ fail1:
 
 NTSTATUS
 RegistryQuerySystemStartOption(
-    _In_ PCHAR                      Prefix,
+    _In_ PSTR                       Prefix,
     _Outptr_ PANSI_STRING           *Value
     )
 {
@@ -1536,7 +1536,7 @@ fail1:
 NTSTATUS
 RegistryUpdateSzValue(
     _In_ HANDLE                     Key,
-    _In_ PCHAR                      Name,
+    _In_ PSTR                       Name,
     _In_ ULONG                      Type,
     _In_ PANSI_STRING               Array
     )
diff --git a/src/xenvkbd/registry.h b/src/xenvkbd/registry.h
index 29ae4e2..ae3eec1 100644
--- a/src/xenvkbd/registry.h
+++ b/src/xenvkbd/registry.h
@@ -97,7 +97,7 @@ RegistryOpenSubKey(
 extern NTSTATUS
 RegistryCreateSubKey(
     _In_ HANDLE     Key,
-    _In_ PCHAR      Name,
+    _In_ PSTR       Name,
     _In_ ULONG      Options,
     _Out_ PHANDLE   SubKey
     );
@@ -105,7 +105,7 @@ RegistryCreateSubKey(
 extern NTSTATUS
 RegistryDeleteSubKey(
     _In_ HANDLE Key,
-    _In_ PCHAR  Name
+    _In_ PSTR   Name
     );
 
 extern NTSTATUS
@@ -125,27 +125,27 @@ RegistryEnumerateValues(
 extern NTSTATUS
 RegistryDeleteValue(
     _In_ HANDLE Key,
-    _In_ PCHAR  Name
+    _In_ PSTR   Name
     );
 
 extern NTSTATUS
 RegistryQueryDwordValue(
     _In_ HANDLE     Key,
-    _In_ PCHAR      Name,
+    _In_ PSTR       Name,
     _Out_ PULONG    Value
     );
     
 extern NTSTATUS
 RegistryUpdateDwordValue(
     _In_ HANDLE Key,
-    _In_ PCHAR  Name,
+    _In_ PSTR   Name,
     _In_ ULONG  Value
     );
     
 extern NTSTATUS
 RegistryQuerySzValue(
     _In_ HANDLE             Key,
-    _In_ PCHAR              Name,
+    _In_ PSTR               Name,
     _Out_opt_ PULONG        Type,
     _Outptr_ PANSI_STRING   *Array
     );
@@ -153,7 +153,7 @@ RegistryQuerySzValue(
 extern NTSTATUS
 RegistryQueryBinaryValue(
     _In_ HANDLE     Key,
-    _In_ PCHAR      Name,
+    _In_ PSTR       Name,
     _Outptr_ PVOID  *Buffer,
     _Out_ PULONG    Length
     );
@@ -161,7 +161,7 @@ RegistryQueryBinaryValue(
 extern NTSTATUS
 RegistryUpdateBinaryValue(
     _In_ HANDLE Key,
-    _In_ PCHAR  Name,
+    _In_ PSTR   Name,
     _In_ PVOID  Buffer,
     _In_ ULONG  Length
     );
@@ -174,7 +174,7 @@ RegistryQueryKeyName(
 
 extern NTSTATUS
 RegistryQuerySystemStartOption(
-    _In_ PCHAR              Name,
+    _In_ PSTR               Name,
     _Outptr_ PANSI_STRING   *Option
     );
 
@@ -191,7 +191,7 @@ RegistryFreeBinaryValue(
 extern NTSTATUS
 RegistryUpdateSzValue(
     _In_ HANDLE         Key,
-    _In_ PCHAR          Name,
+    _In_ PSTR           Name,
     _In_ ULONG          Type,
     _In_ PANSI_STRING   Array
     );
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.