Re: [XenPPC] __XEN_INTERFACE_VERSION__

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Thu, 2006-09-07 at 16:27 +1000, Tony Breeds wrote:
> On Thu, Sep 07, 2006 at 12:57:42AM -0400, Jimi Xenidis wrote:
> > BTW: WRT __XEN_INTERFACE_VERSION__, IMHO, Tony's patch got it right.
> > I was not able to quickly figure out how Hollis did it, here is the  
> > diff from Tony:
> 
> Hollis does it here:
> 
> --- a/arch/powerpc/platforms/xen/Makefile       Tue Sep 05 18:00:40 2006 -0500
> +++ b/arch/powerpc/platforms/xen/Makefile       Wed Sep 06 09:08:21 2006 -0500
> @@ -1,4 +1,7 @@ obj-y   += setup.o evtchn.o hcall.o udbg_x
>  obj-y  += setup.o evtchn.o hcall.o udbg_xen.o xen_guest.o reboot.o
> +
> +# we need the latest __XEN_INTERFACE_VERSION__ (see xen-compat.h)
> +CFLAGS_hcall.o += -D__XEN_TOOLS__
> 
> xen-compat.h has:
> ---
> #define __XEN_LATEST_INTERFACE_VERSION__ 0x00030204
> 
> #if defined(__XEN__) || defined(__XEN_TOOLS__)
> /* Xen is built with matching headers and implements the latest
>  * interface. */
>  #define __XEN_INTERFACE_VERSION__ __XEN_LATEST_INTERFACE_VERSION_
> ---
> 
> If I understand correctly basically Hollis is only defining
> __XEN_INTERFACE_VERSION__ for theone file it's needed.

Yes. It makes sense, and it's also what Keir specifically suggested.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel