WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] heads up: large nasty merge

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [XenPPC] heads up: large nasty merge
From: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
Date: Thu, 7 Sep 2006 16:27:53 +1000
Cc: "Hollis R. Blanchard" <hollisb@xxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 06 Sep 2006 23:28:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4CD5A1A1-EBC4-4539-BA1C-6E8E2ACB56D4@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, "Hollis R. Blanchard" <hollisb@xxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
References: <1157497495.20425.72.camel@xxxxxxxxxxxxxxxxxxxxx> <20060906060025.GQ27551@xxxxxxxxxxxxxxxxxx> <44FEA093.7030705@xxxxxxxxxxxxx> <233E9F8C-EF68-4C9E-A70B-3B50AA28BF14@xxxxxxxxxxxxxx> <918FD6C7-7F3E-4DA4-B125-7F4317287EFB@xxxxxxxxxxxxxx> <1157552161.15004.2.camel@xxxxxxxxxxxxxxxxxxxxx> <20060906223905.GR27551@xxxxxxxxxxxxxxxxxx> <4CD5A1A1-EBC4-4539-BA1C-6E8E2ACB56D4@xxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Sep 07, 2006 at 12:57:42AM -0400, Jimi Xenidis wrote:
> BTW: WRT __XEN_INTERFACE_VERSION__, IMHO, Tony's patch got it right.
> I was not able to quickly figure out how Hollis did it, here is the  
> diff from Tony:

Hollis does it here:

--- a/arch/powerpc/platforms/xen/Makefile       Tue Sep 05 18:00:40 2006 -0500
+++ b/arch/powerpc/platforms/xen/Makefile       Wed Sep 06 09:08:21 2006 -0500
@@ -1,4 +1,7 @@ obj-y   += setup.o evtchn.o hcall.o udbg_x
 obj-y  += setup.o evtchn.o hcall.o udbg_xen.o xen_guest.o reboot.o
+
+# we need the latest __XEN_INTERFACE_VERSION__ (see xen-compat.h)
+CFLAGS_hcall.o += -D__XEN_TOOLS__

xen-compat.h has:
---
#define __XEN_LATEST_INTERFACE_VERSION__ 0x00030204

#if defined(__XEN__) || defined(__XEN_TOOLS__)
/* Xen is built with matching headers and implements the latest
 * interface. */
 #define __XEN_INTERFACE_VERSION__ __XEN_LATEST_INTERFACE_VERSION_
---

If I understand correctly basically Hollis is only defining
__XEN_INTERFACE_VERSION__ for theone file it's needed.

Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel