Hi Alex,
Sorry for that.
I have been using XEN standard style, four space chars indent.
And I didn't notice some files still use tab indent.
The new one fixes style and some codes are modified per yamahata's comments.
Please apply this patch.
Thanks,
-Anthony
>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson@xxxxxx]
>Sent: 2006?3?29? 1:07
>To: Xu, Anthony
>Cc: xen-ia64-devel
>Subject: Re: [Xen-ia64-devel] [PATCH] Enable hash vtlb on dom0&domU
>
>On Tue, 2006-03-28 at 23:42 +0800, Xu, Anthony wrote:
>> This patch is intended to enable hash vtlb on dom0&domU.
>> It's an option, and is turned off by default.
>> If you want to turn on it, uncomment below line in file
>> xen/arch/ia64/Rules.mk.
>> #CFLAGS += -DHASH_VHPT
>
>Hi Anthony,
>
> Sorry to pick on style, but there's lots of extraneous and
>inconsistent formatting in this patch. It might be helpful to set the
>tab stop to something other than 4 to make these more obvious. It's
>also important to review the patch file itself before submitting as
>these kinds of changes can be more apparent when viewed on their own.
>
> I sometimes try to correct these on the fly before committing the
>patch, but as Hollis has noted on xen-devel[1], modifying patches is not
>in keeping with the Developer Certificate of Origin. This is a general
>reminder to everyone submitting patches, I'm not trying to pick on this
>one in particular. The only rule I'm trying to enforce is consistency,
>preferably across a file, but at least within a function if the file
>already uses mixed formatting. Thanks,
>
> Alex
>
>[1]
>http://lists.xensource.com/archives/html/xen-devel/2006-03/msg01235.html
>
>--
>Alex Williamson HP Linux & Open Source Lab
enable_hash_vtlb2.diff
Description: enable_hash_vtlb2.diff
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
Home